fix: don't construct submenu if it's invisible (#16834)

electron · Feb 8, 2019 · 062778c · 062778c
1 parent 833daaa
commit 062778c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm
@@ -220,7 +220,8 @@ - (void)addItemToMenu:(NSMenu*)menu
     NSMenu* submenu = [[NSMenu alloc] initWithTitle:label];
     [item setSubmenu:submenu];
     [NSApp setServicesMenu:submenu];
-  } else if (type == atom::AtomMenuModel::TYPE_SUBMENU) {
+  } else if (type == atom::AtomMenuModel::TYPE_SUBMENU &&
+             model->IsVisibleAt(index)) {
     // Recursively build a submenu from the sub-model at this index.
     [item setTarget:nil];
     [item setAction:nil];