I swear this isn't tricking the linter

electron · May 3, 2018 · 067234e · 067234e
1 parent 0e83284
commit 067234e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/docs/api/app.md b/docs/api/app.md
@@ -801,12 +801,12 @@ app.on('second-instance', (commandLine, workingDirectory) => {
 })
 
 if (!gotTheLock) {
-  return app.quit()
+  app.quit()
+} else {
+  // Create myWindow, load the rest of the app, etc...
+  app.on('ready', () => {
+  })
 }
-
-// Create myWindow, load the rest of the app, etc...
-app.on('ready', () => {
-})
 ```
 
 ### `app.hasSingleInstanceLock()`

diff --git a/lib/browser/api/app.js b/lib/browser/api/app.js
@@ -110,10 +110,10 @@ for (let name of events) {
 }
 
 // TODO(MarshallOfSound): Remove in 4.0
-app.makeSingleInstance = (cb) => {
+app.makeSingleInstance = (oldStyleFn) => {
   deprecate.warn('app.makeSingleInstance(cb)', 'app.requestSingleInstanceLock() and app.on(\'second-instance\', cb)')
-  if (cb && typeof cb === 'function') {
-    app.on('second-instance', (event, ...args) => cb(...args))
+  if (oldStyleFn && typeof oldStyleFn === 'function') {
+    app.on('second-instance', (event, ...args) => oldStyleFn(...args))
   }
   return !app.requestSingleInstanceLock()
 }