properly deprecate method for backwards compat

electron · Nov 19, 2018 · 06ce20a · 06ce20a
1 parent cf0333f
commit 06ce20a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/browser/api/app.js b/lib/browser/api/app.js
@@ -40,9 +40,14 @@ Object.assign(app, {
   }
 })
 
-const nativeFn = app.getAppMetrics
+const nativeGetFileIcon = app.getFileIcon
+app.getFileIcon = (path, options = {}, cb) => {
+  return deprecate.promisify(nativeGetFileIcon.call(app, path, options), cb)
+}
+
+const nativeAppMetrics = app.getAppMetrics
 app.getAppMetrics = () => {
-  const metrics = nativeFn.call(app)
+  const metrics = nativeAppMetrics.call(app)
   for (const metric of metrics) {
     if ('memory' in metric) {
       deprecate.removeProperty(metric, 'memory')