Skip to content

Commit

Permalink
fix: register accelerator if role has no registerAccelerator (backpor…
Browse files Browse the repository at this point in the history
…t: 4-0-x) (#16314)

* fix: register accelerator if role has no registerAccelerator

* ensure roles[role].registerAccelerator is defined
  • Loading branch information
trop[bot] authored and John Kleinschmidt committed Jan 8, 2019
1 parent bad9ff6 commit 0b6cc93
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/browser/api/menu-item-roles.js
Expand Up @@ -248,7 +248,8 @@ exports.getDefaultAccelerator = (role) => {
}

exports.shouldRegisterAccelerator = (role) => {
return roles.hasOwnProperty(role) ? roles[role].registerAccelerator : true
const hasRoleRegister = roles.hasOwnProperty(role) && roles[role].registerAccelerator !== undefined
return hasRoleRegister ? roles[role].registerAccelerator : true
}

exports.getDefaultSubmenu = (role) => {
Expand Down

0 comments on commit 0b6cc93

Please sign in to comment.