fixup! fix: throw a new exception for safeStorage before app is ready

Signed-off-by: Darshan Sen <raisinten@gmail.com>
electron · May 5, 2022 · 17c80bb · 17c80bb
1 parent 6107654
commit 17c80bb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/shell/browser/api/electron_api_safe_storage.cc b/shell/browser/api/electron_api_safe_storage.cc
@@ -75,7 +75,7 @@ std::string DecryptString(v8::Isolate* isolate, v8::Local<v8::Value> buffer) {
     if (!Browser::Get()->is_ready()) {
       gin_helper::ErrorThrower(isolate).ThrowError(
           "safeStorage cannot be used before app is ready");
-      return v8::Local<v8::Value>();
+      return "";
     }
     gin_helper::ErrorThrower(isolate).ThrowError(
         "Error while decrypting the ciphertext provided to "