fix: app.dock.setIcon() crash before app ready (#36279)

fix: dock.setIcon() crash before app ready
electron · Nov 9, 2022 · 1b1609a · 1b1609a
1 parent 5fc3ed9
commit 1b1609a
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/shell/browser/browser_mac.mm b/shell/browser/browser_mac.mm
@@ -447,6 +447,13 @@
     image = native_image->image();
   }
 
+  // This is needed when this fn is called before the browser
+  // process is ready, since supported scales are normally set
+  // by ui::ResourceBundle::InitSharedInstance
+  // during browser process startup.
+  if (!is_ready())
+    gfx::ImageSkia::SetSupportedScales({1.0f});
+
   [[AtomApplication sharedApplication]
       setApplicationIconImage:image.AsNSImage()];
 }