Remove redundant promise rejection callback

nodejs/node#34387
electron · Sep 14, 2020 · 1e6f14e · 1e6f14e
1 parent f258600
commit 1e6f14e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 53 deletions.
diff --git a/patches/node/.patches b/patches/node/.patches
@@ -27,7 +27,6 @@ fix_use_crypto_impls_for_compat.patch
 fix_window_c-ares_incompatibilities.patch
 fix_comment_out_incompatible_crypto_modules.patch
 update_tests_after_increasing_typed_array_size.patch
-fix_allow_preventing_setpromiserejectcallback.patch
 lib_use_non-symbols_in_isurlinstance_check.patch
 feat_add_implementation_of_v8_platform_postjob.patch
 fix_enable_tls_renegotiation.patch

diff --git a/patches/node/fix_allow_preventing_setpromiserejectcallback.patch b/patches/node/fix_allow_preventing_setpromiserejectcallback.patch
diff --git a/shell/common/node_bindings.cc b/shell/common/node_bindings.cc
@@ -450,8 +450,8 @@ node::Environment* NodeBindings::CreateEnvironment(
     // We do not want to use the promise rejection callback that Node.js uses,
     // because it does not send PromiseRejectionEvents to the global script
     // context. We need to use the one Blink already provides.
-    is.flags &=
-        ~node::IsolateSettingsFlags::SHOULD_SET_PROMISE_REJECTION_CALLBACK;
+    is.flags |=
+        node::IsolateSettingsFlags::SHOULD_NOT_SET_PROMISE_REJECTION_CALLBACK;
   }
 
   // This needs to be called before the inspector is initialized.