feat: support capslock and numlock as accelerators (backport: 5-0-x) (#…

…16725) * feat: support capslock as accelerator * also add numlock
electron · Feb 11, 2019 · 30cc82d · 30cc82d
1 parent 14c3962
commit 30cc82d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/atom/common/keyboard_util.cc b/atom/common/keyboard_util.cc
@@ -38,6 +38,10 @@ ui::KeyboardCode KeyboardCodeFromKeyIdentifier(const std::string& s,
   } else if (str == "plus") {
     *shifted = true;
     return ui::VKEY_OEM_PLUS;
+  } else if (str == "capslock") {
+    return ui::VKEY_CAPITAL;
+  } else if (str == "numlock") {
+    return ui::VKEY_NUMLOCK;
   } else if (str == "tab") {
     return ui::VKEY_TAB;
   } else if (str == "num0") {

diff --git a/docs/api/accelerator.md b/docs/api/accelerator.md
@@ -58,6 +58,8 @@ The `Super` key is mapped to the `Windows` key on Windows and Linux and
 * `Plus`
 * `Space`
 * `Tab`
+* `Capslock`
+* `Numlock`
 * `Backspace`
 * `Delete`
 * `Insert`