fix: race condition where webContents can be nullptr during re-focus …

…and a multi-window close sequence (#33284) * fix: race condition where webContents can be nullptr during re-focus and a multi-window close sequence * chore: update electron_inspectable_web_contents_view.mm Co-authored-by: Samuel Attard <sam@electronjs.org>
electron · Mar 21, 2022 · 388acd7 · 388acd7
1 parent 46d7439
commit 388acd7
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/shell/browser/ui/cocoa/electron_inspectable_web_contents_view.mm b/shell/browser/ui/cocoa/electron_inspectable_web_contents_view.mm
@@ -266,6 +266,8 @@ - (void)viewDidBecomeFirstResponder:(NSNotification*)notification {
       inspectableWebContentsView_->inspectable_web_contents();
   DCHECK(inspectable_web_contents);
   auto* webContents = inspectable_web_contents->GetWebContents();
+  if (!webContents)
+    return;
   auto* webContentsView = webContents->GetNativeView().GetNativeNSView();
 
   NSView* view = [notification object];