fix: do not DCHECK production-necessary methods (#20836)

electron · Oct 29, 2019 · 3aa33dd · 3aa33dd
1 parent 9b74d0d
commit 3aa33dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/shell/renderer/atom_renderer_client.cc b/shell/renderer/atom_renderer_client.cc
@@ -121,7 +121,9 @@ void AtomRendererClient::DidCreateScriptContext(
     node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
 
   // Setup node environment for each window.
-  DCHECK(node::InitializeContext(renderer_context));
+  bool initialized = node::InitializeContext(renderer_context);
+  CHECK(initialized);
+
   node::Environment* env =
       node_bindings_->CreateEnvironment(renderer_context, nullptr, true);
 

diff --git a/shell/renderer/web_worker_observer.cc b/shell/renderer/web_worker_observer.cc
@@ -48,7 +48,8 @@ void WebWorkerObserver::ContextCreated(v8::Local<v8::Context> worker_context) {
   node_bindings_->PrepareMessageLoop();
 
   // Setup node environment for each window.
-  DCHECK(node::InitializeContext(worker_context));
+  bool initialized = node::InitializeContext(worker_context);
+  CHECK(initialized);
   node::Environment* env =
       node_bindings_->CreateEnvironment(worker_context, nullptr, true);