fix: tray icon not highlighting on empty menu (#34205)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
electron · May 12, 2022 · 3d82701 · 3d82701
1 parent a6cee3a
commit 3d82701
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm
@@ -193,9 +193,9 @@ - (void)mouseDown:(NSEvent*)event {
       gfx::ScreenPointFromNSPoint([event locationInWindow]),
       ui::EventFlagsFromModifiers([event modifierFlags]));
 
-  // Pass click to superclass to show menu. Custom mouseUp handler won't be
-  // invoked.
-  if (menuController_) {
+  // Pass click to superclass to show menu if one exists and has a non-zero
+  // number of items. Custom mouseUp handler won't be invoked in this case.
+  if (menuController_ && [[menuController_ menu] numberOfItems] > 0) {
     [self handleClickNotifications:event];
     [super mouseDown:event];
   } else {