chore: add menu-will-close comment explaining setTimeout (#16794)

electron · Feb 8, 2019 · 3f52e18 · 3f52e18
1 parent 70042d2
commit 3f52e18
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/browser/chrome-devtools.js b/lib/browser/chrome-devtools.js
@@ -71,6 +71,9 @@ ipcMainUtils.handle('ELECTRON_INSPECTOR_CONTEXT_MENU', function (event, items, i
   const window = event.sender.getOwnerBrowserWindow()
 
   menu.once('menu-will-close', () => {
+    // menu-will-close is emitted before the click handler, but needs to be sent after.
+    // otherwise, DevToolsAPI.contextMenuCleared() would be called before
+    // DevToolsAPI.contextMenuItemSelected(id) and the menu will not work properly.
     setTimeout(() => {
       event._replyInternal('ELECTRON_INSPECTOR_CONTEXT_MENU_CLOSE')
     })