-
Notifications
You must be signed in to change notification settings - Fork 15k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: add support for externally shared js builtins
- Loading branch information
1 parent
d44581f
commit 3faa1d0
Showing
3 changed files
with
32 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Shelley Vohr <shelley.vohr@gmail.com> | ||
Date: Mon, 9 Jan 2023 14:34:01 +0100 | ||
Subject: chore: remove unreached return | ||
|
||
https://github.com/nodejs/node/pull/44376 added a return after a call to | ||
ABORT(), triggering an unreachable code error. | ||
|
||
This should be upstreamed. | ||
|
||
diff --git a/src/node_builtins.cc b/src/node_builtins.cc | ||
index 25b02f9904127780c68db9b451a7dfcf02a6fc5e..1be20aea500fd9d606c5a38a86b4aef66b49d133 100644 | ||
--- a/src/node_builtins.cc | ||
+++ b/src/node_builtins.cc | ||
@@ -247,7 +247,6 @@ void BuiltinLoader::AddExternalizedBuiltin(const char* id, | ||
fprintf( | ||
stderr, "Cannot load externalized builtin: \"%s:%s\".\n", id, filename); | ||
ABORT(); | ||
- return; | ||
} | ||
|
||
icu::UnicodeString utf16 = icu::UnicodeString::fromUTF8( |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters