Skip to content

Commit

Permalink
chore: skip the .bin from folder hashing due to npm not cleaning up s…
Browse files Browse the repository at this point in the history
…ymlinks (#14888)

 - fix the ia32 specs not running on CI
 - handle rejected promises in the "spec-runner" script
  • Loading branch information
MarshallOfSound authored and alexeykuzmin committed Oct 1, 2018
1 parent 60ac03c commit 40b676f
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion script/spec-runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ getSpecHash().then(([currentSpecHash, currentSpecInstallHash]) => {
child.on('exit', (code) => {
process.exit(code)
})
}).catch((error) => {
console.error('An error occurred inside the spec runner', error)
process.exit(1)
})

function getSpecHash () {
Expand All @@ -67,7 +70,11 @@ function getSpecHash () {
if (!fs.existsSync(specNodeModulesPath)) {
return resolve('invalid')
}
hashElement(specNodeModulesPath).then((result) => resolve(result.hash)).catch(reject)
hashElement(specNodeModulesPath, {
folders: {
exclude: ['.bin']
}
}).then((result) => resolve(result.hash)).catch(reject)
})
])
}

0 comments on commit 40b676f

Please sign in to comment.