chore: Update comment for desktop_capturer (#19848)

* chore: Update comment for desktop_capturer * Guard TopLevelWindow::MoveAbove with ENABLE_DESKTOP_CAPTURER * Fix lint errors
electron · Aug 21, 2019 · 46b6bcd · 46b6bcd
1 parent 4bc7b3b
commit 46b6bcd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/BUILD.gn b/BUILD.gn
@@ -583,6 +583,9 @@ source_set("electron_lib") {
 
   if (enable_desktop_capturer) {
     if (is_component_build && !is_linux) {
+      # On windows the implementation relies on unexported
+      # DxgiDuplicatorController class.  On macOS the implementation
+      # relies on unexported webrtc::GetWindowOwnerPid method.
       deps += [ "//third_party/webrtc/modules/desktop_capture" ]
     }
     sources += [

diff --git a/shell/browser/api/atom_api_top_level_window.cc b/shell/browser/api/atom_api_top_level_window.cc
@@ -555,8 +555,12 @@ std::vector<int> TopLevelWindow::GetPosition() {
 }
 void TopLevelWindow::MoveAbove(const std::string& sourceId,
                                mate::Arguments* args) {
+#if BUILDFLAG(ENABLE_DESKTOP_CAPTURER)
   if (!window_->MoveAbove(sourceId))
     args->ThrowError("Invalid media source id");
+#else
+  args->ThrowError("enable_desktop_capturer=true to use this feature");
+#endif
 }
 
 void TopLevelWindow::MoveTop() {