wip: async

electron · Jul 24, 2019 · 4fbbc47 · 4fbbc47
1 parent d5fbbec
commit 4fbbc47
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/shell/browser/browser_win.cc b/shell/browser/browser_win.cc
@@ -412,8 +412,10 @@ void Browser::ShowAboutPanel() {
   settings.icon = image;
   settings.type = electron::MessageBoxType::kInformation;
   // TODO(erickzhao): make asynchronous to avoid blocking js code
-  // TODO(erickzhao): add icon (?)
-  electron::ShowMessageBoxSync(settings);
+  electron::ShowMessageBox(
+      settings, base::BindOnce([](int code, bool checkbox_checked) -> void {
+        LOG(INFO) << "callback";
+      }));
 }
 
 void Browser::SetAboutPanelOptions(const base::DictionaryValue& options) {