fix: make isDarkMode correctly detect dark mode in the auto setting o…

…n catalina (#18959)
electron · Jun 24, 2019 · 52c76fc · 52c76fc
1 parent a568e13
commit 52c76fc
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/atom/browser/api/atom_api_system_preferences_mac.mm b/atom/browser/api/atom_api_system_preferences_mac.mm
@@ -439,6 +439,10 @@ AVMediaType ParseMediaType(const std::string& media_type) {
 }
 
 bool SystemPreferences::IsDarkMode() {
+  if (@available(macOS 10.14, *)) {
+    return [[NSApplication sharedApplication].effectiveAppearance.name
+        isEqualToString:NSAppearanceNameDarkAqua];
+  }
   NSString* mode = [[NSUserDefaults standardUserDefaults]
       stringForKey:@"AppleInterfaceStyle"];
   return [mode isEqualToString:@"Dark"];