fix: use hasOwnProperty to test key

electron · Jan 14, 2020 · 5418580 · 5418580
1 parent 8c44079
commit 5418580
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/browser/api/net.js b/lib/browser/api/net.js
@@ -55,20 +55,21 @@ class IncomingMessage extends Readable {
     const filteredHeaders = {}
     const { rawHeaders } = this._responseHead
     rawHeaders.forEach(header => {
-      if (header.key in filteredHeaders && discardableDuplicateHeaders.has(header.key)) {
+      if (Object.prototype.hasOwnProperty.call(filteredHeaders, header.key) &&
+          discardableDuplicateHeaders.has(header.key)) {
         // do nothing with discardable duplicate headers
       } else {
         if (header.key === 'set-cookie') {
           // keep set-cookie as an array per Node.js rules
           // see https://nodejs.org/api/http.html#http_message_headers
-          if (filteredHeaders[header.key]) {
+          if (Object.prototype.hasOwnProperty.call(filteredHeaders, header.key)) {
             filteredHeaders[header.key].push(header.value)
           } else {
             filteredHeaders[header.key] = [header.value]
           }
         } else {
           // for non-cookie headers, the values are joined together with ', '
-          if (filteredHeaders[header.key]) {
+          if (Object.prototype.hasOwnProperty.call(filteredHeaders, header.key)) {
             filteredHeaders[header.key] += `, ${header.value}`
           } else {
             filteredHeaders[header.key] = header.value