Update based on review

electron · Feb 13, 2019 · 54f0131 · 54f0131
1 parent 83b583c
commit 54f0131
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 699 deletions.
diff --git a/atom/renderer/api/atom_api_web_frame.cc b/atom/renderer/api/atom_api_web_frame.cc
@@ -401,18 +401,8 @@ void SetIsolatedWorldHumanReadableName(v8::Local<v8::Value> window,
 
 void SetIsolatedWorldInfo(v8::Local<v8::Value> window,
                           int world_id,
+                          const mate::Dictionary& options,
                           mate::Arguments* args) {
-  if (args->Length() < 1) {
-    args->ThrowError("Invalid args");
-    return;
-  }
-
-  mate::Dictionary options;
-  if (!args->GetNext(&options)) {
-    args->ThrowError("Must pass valid object");
-    return;
-  }
-
   std::string origin, csp, name;
   options.Get("securityOrigin", &origin);
   options.Get("csp", &csp);