fix: make isDarkMode correctly detect dark mode in the auto setting o…

…n catalina (#18949)
electron · Jun 24, 2019 · 5686a07 · 5686a07
1 parent 1cd7c21
commit 5686a07
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/shell/browser/api/atom_api_system_preferences_mac.mm b/shell/browser/api/atom_api_system_preferences_mac.mm
@@ -628,6 +628,10 @@ AVMediaType ParseMediaType(const std::string& media_type) {
 }
 
 bool SystemPreferences::IsDarkMode() {
+  if (@available(macOS 10.14, *)) {
+    return [[NSApplication sharedApplication].effectiveAppearance.name
+        isEqualToString:NSAppearanceNameDarkAqua];
+  }
   NSString* mode = [[NSUserDefaults standardUserDefaults]
       stringForKey:@"AppleInterfaceStyle"];
   return [mode isEqualToString:@"Dark"];