apply same fix to protocol

electron · Mar 24, 2019 · 5dea4eb · 5dea4eb
1 parent 6b441ed
commit 5dea4eb
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/browser/api/protocol.ts b/lib/browser/api/protocol.ts
@@ -11,8 +11,12 @@ Object.setPrototypeOf(protocol, new Proxy({}, {
     const protocol = session.defaultSession!.protocol
     if (!Object.getPrototypeOf(protocol).hasOwnProperty(property)) return
 
+    // check for properties on the prototype chain  that aren't functions
+    const propertyValue = protocol[property as keyof Electron.Protocol]
+    if (typeof propertyValue !== 'function') return propertyValue
+
     // Returning a native function directly would throw error.
-    return (...args: any[]) => (protocol[property as keyof Electron.Protocol] as Function)(...args)
+    return (...args: any[]) => (propertyValue as Function)(...args)
   },
 
   ownKeys () {