Skip to content

Commit

Permalink
fix: generate breakpad symbols before stripping (#20530)
Browse files Browse the repository at this point in the history
* fix: generate breakpad symbols before stripping

* store symbols as circleci artifacts
  • Loading branch information
nornagon authored and John Kleinschmidt committed Oct 14, 2019
1 parent 8efa45d commit 6025ae7
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .circleci/config.yml
Expand Up @@ -553,6 +553,11 @@ step-maybe-zip-symbols: &step-maybe-zip-symbols
ninja -C out/Default electron:electron_version
electron/script/zip-symbols.py -b $BUILD_PATH
step-symbols-store: &step-symbols-store
store_artifacts:
path: src/out/Default/symbols.zip
destination: symbols.zip

step-maybe-cross-arch-snapshot: &step-maybe-cross-arch-snapshot
run:
name: Generate cross arch snapshot (arm/arm64)
Expand Down Expand Up @@ -859,6 +864,7 @@ steps-electron-build: &steps-electron-build

- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test
Expand Down Expand Up @@ -933,6 +939,7 @@ steps-electron-build-with-inline-checkout-for-tests: &steps-electron-build-with-

- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test
Expand All @@ -953,11 +960,12 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish

# Electron app
- *step-electron-build
- *step-maybe-generate-breakpad-symbols
- *step-maybe-electron-dist-strip
- *step-electron-dist-build
- *step-electron-dist-store
- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols
- *step-symbols-store

# mksnapshot
- *step-mksnapshot-build
Expand Down

0 comments on commit 6025ae7

Please sign in to comment.