Skip to content

Commit

Permalink
chore: fixup bad rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
MarshallOfSound committed Apr 28, 2019
1 parent e8b852b commit 6229174
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 31 deletions.
31 changes: 0 additions & 31 deletions atom/browser/atom_browser_main_parts.cc
Expand Up @@ -199,37 +199,6 @@ int X11EmptyIOErrorHandler(Display* d) {

} // namespace

void AtomBrowserMainParts::InitializeFeatureList() {
auto* cmd_line = base::CommandLine::ForCurrentProcess();
auto enable_features =
cmd_line->GetSwitchValueASCII(::switches::kEnableFeatures);
auto disable_features =
cmd_line->GetSwitchValueASCII(::switches::kDisableFeatures);
// Disable creation of spare renderer process with site-per-process mode,
// it interferes with our process preference tracking for non sandboxed mode.
// Can be reenabled when our site instance policy is aligned with chromium
// when node integration is enabled.
disable_features +=
std::string(",") + features::kSpareRendererForSitePerProcess.name;
#if !BUILDFLAG(ENABLE_PICTURE_IN_PICTURE)
disable_features += std::string(",") + media::kPictureInPicture.name;
#endif
auto feature_list = std::make_unique<base::FeatureList>();
feature_list->InitializeFromCommandLine(enable_features, disable_features);
base::FeatureList::SetInstance(std::move(feature_list));
}

#if !defined(OS_MACOSX)
void AtomBrowserMainParts::OverrideAppLogsPath() {
base::FilePath path;
if (base::PathService::Get(DIR_APP_DATA, &path)) {
path = path.Append(base::FilePath::FromUTF8Unsafe(GetApplicationName()));
path = path.Append(base::FilePath::FromUTF8Unsafe("logs"));
base::PathService::Override(DIR_APP_LOGS, path);
}
}
#endif

// static
AtomBrowserMainParts* AtomBrowserMainParts::self_ = nullptr;

Expand Down
4 changes: 4 additions & 0 deletions atom/browser/feature_list.cc
Expand Up @@ -10,6 +10,7 @@
#include "base/command_line.h"
#include "base/feature_list.h"
#include "content/public/common/content_features.h"
#include "electron/buildflags/buildflags.h"

namespace atom {

Expand All @@ -19,6 +20,9 @@ void InitializeFeatureList() {
cmd_line->GetSwitchValueASCII(::switches::kEnableFeatures);
auto disable_features =
cmd_line->GetSwitchValueASCII(::switches::kDisableFeatures);
#if !BUILDFLAG(ENABLE_PICTURE_IN_PICTURE)
disable_features += std::string(",") + media::kPictureInPicture.name;
#endif
// Disable creation of spare renderer process with site-per-process mode,
// it interferes with our process preference tracking for non sandboxed mode.
// Can be reenabled when our site instance policy is aligned with chromium
Expand Down

0 comments on commit 6229174

Please sign in to comment.