Skip to content

Commit

Permalink
is_empty -> is_valid
Browse files Browse the repository at this point in the history
  • Loading branch information
Micha Hanselmann committed Jun 13, 2019
1 parent 7c76d0e commit 677a040
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion atom/browser/api/atom_api_cookies.cc
Expand Up @@ -258,7 +258,7 @@ v8::Local<v8::Promise> Cookies::Set(const base::DictionaryValue& details) {
: base::Time::UnixEpoch();

GURL url(url_string ? *url_string : "");
if (url.is_empty()) {
if (url.is_valid()) {
promise.RejectWithErrorMessage(InclusionStatusToString(
net::CanonicalCookie::CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN));
return handle;
Expand Down

0 comments on commit 677a040

Please sign in to comment.