Skip to content

Commit

Permalink
fix: Uncaught TypeError: Cannot set property 'innerText' of null in d…
Browse files Browse the repository at this point in the history
…efault-app (#18818)
  • Loading branch information
miniak authored and codebytere committed Jun 17, 2019
1 parent 1ae0d41 commit 690e94a
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions default_app/renderer.js
Expand Up @@ -26,11 +26,18 @@ function initialize () {
link.addEventListener('auxclick', openLinkExternally)
}

document.querySelector('.electron-version').innerText = `Electron v${process.versions.electron}`
document.querySelector('.chrome-version').innerText = `Chromium v${process.versions.chrome}`
document.querySelector('.node-version').innerText = `Node v${process.versions.node}`
document.querySelector('.v8-version').innerText = `v8 v${process.versions.v8}`
document.querySelector('.command-example').innerText = `${electronPath} path-to-app`
function replaceText (selector, text) {
const element = document.querySelector(selector)
if (element) {
element.innerText = text
}
}

replaceText('.electron-version', `Electron v${process.versions.electron}`)
replaceText('.chrome-version', `Chromium v${process.versions.chrome}`)
replaceText('.node-version', `Node v${process.versions.node}`)
replaceText('.v8-version', `v8 v${process.versions.v8}`)
replaceText('.command-example', `${electronPath} path-to-app`)

function getOcticonSvg (name) {
const octiconPath = path.resolve(__dirname, 'node_modules', 'octicons', 'build', 'svg', `${name}.svg`)
Expand Down

0 comments on commit 690e94a

Please sign in to comment.