Fix webContents.print() (#17116)

electron · Feb 27, 2019 · 6d313b4 · 6d313b4
1 parent 330e8ab
commit 6d313b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
@@ -1455,7 +1455,7 @@ bool WebContents::IsDOMReady() const {
 
 #if BUILDFLAG(ENABLE_PRINTING)
 void WebContents::Print(mate::Arguments* args) {
-  bool silent, print_background = false;
+  bool silent = false, print_background = false;
   base::string16 device_name;
   mate::Dictionary options = mate::Dictionary::CreateEmpty(args->isolate());
   base::DictionaryValue settings;

diff --git a/lib/browser/api/web-contents.js b/lib/browser/api/web-contents.js
@@ -263,7 +263,7 @@ WebContents.prototype.printToPDF = function (options, callback) {
 
 WebContents.prototype.print = function (...args) {
   if (features.isPrintingEnabled()) {
-    this._print(args)
+    this._print(...args)
   } else {
     console.error('Error: Printing feature is disabled.')
   }