fix: respect the user's active app focus (#16400)

* Respect the user's active app Apple recommends not setting this to true. https://developer.apple.com/documentation/appkit/nsapplication/1428468-activateignoringotherapps?language=objc * Remove atom_bundle_mover.mm change for [NSApp activateIgnoringOtherApps:]
electron · Feb 26, 2019 · 6da9396 · 6da9396
1 parent 5e762d6
commit 6da9396
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/atom/browser/browser_mac.mm b/atom/browser/browser_mac.mm
@@ -28,7 +28,7 @@
 }
 
 void Browser::Focus() {
-  [[AtomApplication sharedApplication] activateIgnoringOtherApps:YES];
+  [[AtomApplication sharedApplication] activateIgnoringOtherApps:NO];
 }
 
 void Browser::Hide() {

diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm
@@ -521,7 +521,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) {
     return;
 
   if (focus) {
-    [[NSApplication sharedApplication] activateIgnoringOtherApps:YES];
+    [[NSApplication sharedApplication] activateIgnoringOtherApps:NO];
     [window_ makeKeyAndOrderFront:nil];
   } else {
     [window_ orderBack:nil];