fix: return path from netLog.stopLogging (#21988)

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
electron · Jan 31, 2020 · 77448c7 · 77448c7
1 parent 538ebab
commit 77448c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/browser/api/session.js b/lib/browser/api/session.js
@@ -36,8 +36,9 @@ NetLog.prototype.startLogging = function (path, ...args) {
 
 const _originalStopLogging = NetLog.prototype.stopLogging
 NetLog.prototype.stopLogging = function () {
+  const logPath = this._currentlyLoggingPath
   this._currentlyLoggingPath = null
-  return _originalStopLogging.call(this)
+  return _originalStopLogging.call(this).then(() => logPath)
 }
 
 const currentlyLoggingPathDeprecated = deprecate.warnOnce('currentlyLoggingPath')

diff --git a/spec-main/api-net-log-spec.js b/spec-main/api-net-log-spec.js
@@ -70,7 +70,8 @@ describe('netLog module', () => {
 
     expect(testNetLog().currentlyLoggingPath).to.equal(dumpFileDynamic)
 
-    await testNetLog().stopLogging()
+    const path = await testNetLog().stopLogging()
+    expect(path).to.equal(dumpFileDynamic)
 
     expect(fs.existsSync(dumpFileDynamic)).to.be.true()
   })