Skip to content

Commit

Permalink
fix: expose electron/common and electron/renderer modules in sandboxe…
Browse files Browse the repository at this point in the history 
…d preloads (#23893)

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
  • Loading branch information
@trop @MarshallOfSound
trop[bot] and MarshallOfSound committed Jun 2, 2020
1 parent 67be469 commit 79acd3e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/sandboxed_renderer/init.js
View file
Expand Up @@ -45,6 +45,8 @@ const electron = require('electron');

const loadedModules = new Map([
['electron', electron],
['electron/common', electron],
['electron/renderer', electron],

This comment has been minimized.

Sign in to view

Copy link
@webstoreportal

webstoreportal Jun 10, 2021 •
edited

Do we have a change reason for the removal of the RendererInterface type

https://app.renovatebot.com/package-diff?name=electron&from=9.4.4&to=10.0.0#d2h-358059

I have spent a reasonable amount of time and am finding it hard to track down - thinking maybe the changes are dispersed between repos, some doc parser or slurped somewhere else in the https://github.com/electron/typescript-definitions/ definitions repo, which appear to be opaque to searching symbols throughout history

Is this generally trying to discourage usage in a specific way

This comment has been minimized.

Sign in to view

Copy link
@webstoreportal

webstoreportal Jun 10, 2021 •
edited

Replaced with

import type * as Renderer from "electron/renderer";

export type RendererInterface = typeof Renderer;


// or import type { Renderer } from "electron";

For what seems like a minimal SLOC change workaround
['events', events],
['timers', require('timers')],
['url', require('url')]
Expand Down

1 comment on commit 79acd3e

@webstoreportal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a change reason for the removal of RendererInterface

https://app.renovatebot.com/package-diff?name=electron&from=9.4.4&to=10.0.0

I have spent a reasonable amount of time and am finding it hard to track down - thinking maybe the changes are dispersed between repos, some doc parser or slurped somewhere else in the https://github.com/electron/typescript-definitions/ definitions repo, which appear to be opaque to searching symbols throughout history

Please sign in to comment.