Skip to content

Commit

Permalink
chore: rm enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch (#…
Browse files Browse the repository at this point in the history
…34157)

* chore: rm enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch

* chore: update patch
  • Loading branch information
deepak1556 committed May 11, 2022
1 parent a853a6c commit 79e1881
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 45 deletions.
3 changes: 1 addition & 2 deletions patches/node/.patches
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ refactor_allow_embedder_overriding_of_internal_fs_calls.patch
chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch
chore_add_context_to_context_aware_module_prevention.patch
chore_read_nobrowserglobals_from_global_not_process.patch
enable_31_bit_smis_on_64bit_arch_and_ptr_compression.patch
fix_handle_boringssl_and_openssl_incompatibilities.patch
fix_add_v8_enable_reverse_jsargs_defines_in_common_gypi.patch
src_allow_embedders_to_provide_a_custom_pageallocator_to.patch
fix_crypto_tests_to_run_with_bssl.patch
fix_account_for_debugger_agent_race_condition.patch
Expand Down Expand Up @@ -42,3 +40,4 @@ process_fix_hang_after_note_exit_3521.patch
feat_add_uv_loop_interrupt_on_io_change_option_to_uv_loop_configure.patch
fix_preserve_proper_method_names_as-is_in_error_stack.patch
macos_avoid_posix_spawnp_cwd_bug_3597.patch
fix_add_v8_enable_reverse_jsargs_defines_in_common_gypi.patch

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,19 @@ Subject: fix: add v8_enable_reverse_jsargs defines in common.gypi
This can be removed once node upgrades V8 and inevitably has to do this exact same thing. Also hi node people if you are looking at this.

diff --git a/common.gypi b/common.gypi
index 7ffd577817d3c6ae7164dd3945479aedcee9640e..6674f9f9b8880c40db579664fa40f62ad0139368 100644
index 3fd1d4ddddc109dfd87f4ba6115948f1c31b1261..fd4e0b38eb6ecf81b23186ec663499d1e685fdf8 100644
--- a/common.gypi
+++ b/common.gypi
@@ -65,6 +65,7 @@
# node-gyp to build addons.
'v8_enable_pointer_compression%': 0,
'v8_enable_31bit_smis_on_64bit_arch%': 1,
+ 'v8_enable_reverse_jsargs%': 1,

# Disable V8 untrusted code mitigations.
# See https://github.com/v8/v8/wiki/Untrusted-code-mitigations
@@ -82,6 +83,7 @@
@@ -82,6 +82,8 @@
# TODO(refack): make v8-perfetto happen
'v8_use_perfetto': 0,

+ 'v8_enable_reverse_jsargs%': 1,
+
##### end V8 defaults #####

# When building native modules using 'npm install' with the system npm,
@@ -401,6 +403,9 @@
@@ -398,6 +400,9 @@
['v8_enable_pointer_compression == 1 or v8_enable_31bit_smis_on_64bit_arch == 1', {
'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH'],
}],
Expand Down

0 comments on commit 79e1881

Please sign in to comment.