feat: add process.getSystemVersion()

atom/common/api/atom_bindings.cc

@@ -73,6 +73,8 @@ void AtomBindings::BindProcess(v8::Isolate* isolate,
   process->SetMethod("getHeapStatistics", &GetHeapStatistics);
   process->SetMethod("getProcessMemoryInfo", &GetProcessMemoryInfo);
   process->SetMethod("getSystemMemoryInfo", &GetSystemMemoryInfo);
+  process->SetMethod("getSystemVersion",
+                     &base::SysInfo::OperatingSystemVersion);
   process->SetMethod("getIOCounters", &GetIOCounters);
   process->SetMethod("getCPUUsage", base::Bind(&AtomBindings::GetCPUUsage,
                                                base::Unretained(metrics)));

docs/api/process.md

@@ -17,6 +17,7 @@ In sandboxed renderers the `process` object contains only a subset of the APIs:
 - `getHeapStatistics()`
 - `getProcessMemoryInfo()`
 - `getSystemMemoryInfo()`
+- `getSystemVersion()`
 - `getCPUUsage()`
 - `getIOCounters()`
 - `argv`
@@ -83,7 +84,7 @@ instead of the `--no-deprecation` command line flag.
 ### `process.enablePromiseAPIs`
 
 A `Boolean` that controls whether or not deprecation warnings are printed to `stderr` when
-formerly callback-based APIs converted to Promises are invoked using callbacks. Setting this to `true` 
+formerly callback-based APIs converted to Promises are invoked using callbacks. Setting this to `true`
 will enable deprecation warnings.
 
 ### `process.resourcesPath`
@@ -173,7 +174,7 @@ Returns an object with V8 heap statistics. Note that all statistics are reported
 
 Returns `Object`:
 
-* `residentSet` Integer _Linux_ and _Windows_ - The amount of memory 
+* `residentSet` Integer _Linux_ and _Windows_ - The amount of memory
 currently pinned to actual physical RAM in Kilobytes.
 * `private` Integer - The amount of memory not shared by other processes, such as
   JS heap or HTML content in Kilobytes.
@@ -184,7 +185,7 @@ Returns an object giving memory usage statistics about the current process. Note
 that all statistics are reported in Kilobytes.
 This api should be called after app ready.
 
-Chromium does not provide `residentSet` value for macOS. This is because macOS 
+Chromium does not provide `residentSet` value for macOS. This is because macOS
 performs in-memory compression of pages that haven't been recently used. As a
 result the resident set size value is not what one would expect. `private` memory
 is more representative of the actual pre-compression memory usage of the process
@@ -206,6 +207,12 @@ Returns `Object`:
 Returns an object giving memory usage statistics about the entire system. Note
 that all statistics are reported in Kilobytes.
 
+### `process.getSystemVersion()`
+
+Returns `String` - The version of the host operating system.
+
+**Note:** It returns the actual operating system version instead of kernel version on macOS unlike `os.release()`.
+
 ### `process.takeHeapSnapshot(filePath)`
 
 * `filePath` String - Path to the output file.

spec/api-process-spec.js

@@ -59,6 +59,12 @@ describe('process module', () => {
     })
   })
 
+  describe('process.getSystemVersion()', () => {
+    it('returns a string', () => {
+      expect(process.getSystemVersion()).to.be.a('string')
+    })
+  })
+
   describe('process.getHeapStatistics()', () => {
     it('returns heap statistics object', () => {
       const heapStats = process.getHeapStatistics()