chore: fix pageRanges param

electron · Apr 11, 2022 · 7fdb8d2 · 7fdb8d2
1 parent e380281
commit 7fdb8d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/browser/api/web-contents.ts b/lib/browser/api/web-contents.ts
@@ -302,7 +302,7 @@ WebContents.prototype.printToPDF = async function (options) {
   }
 
   if (options.preferCSSPageSize !== undefined) {
-    if (typeof options.preferCSSPageSize !== 'string') {
+    if (typeof options.preferCSSPageSize !== 'boolean') {
       return Promise.reject(new Error('footerTemplate must be a String'));
     }
     printSettings.preferCSSPageSize = options.preferCSSPageSize;

diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts
@@ -1871,10 +1871,7 @@ describe('webContents module', () => {
 
       it('respects custom settings', async () => {
         const data = await w.webContents.printToPDF({
-          pageRanges: {
-            from: 0,
-            to: 2
-          },
+          pageRanges: '1-3',
           landscape: true
         });