fix: use isEqual instead of pointer equality to convert NSAppearance (#…

…18689)
electron · Jun 7, 2019 · 8517c49 · 8517c49
1 parent 3f23f8b
commit 8517c49
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_system_preferences_mac.mm b/atom/browser/api/atom_api_system_preferences_mac.mm
@@ -57,11 +57,11 @@ static bool FromV8(v8::Isolate* isolate,
       return v8::Null(isolate);
     }
 
-    if (val.name == NSAppearanceNameAqua) {
+    if ([val.name isEqualToString:NSAppearanceNameAqua]) {
       return mate::ConvertToV8(isolate, "light");
     }
     if (@available(macOS 10.14, *)) {
-      if (val.name == NSAppearanceNameDarkAqua) {
+      if ([val.name isEqualToString:NSAppearanceNameDarkAqua]) {
         return mate::ConvertToV8(isolate, "dark");
       }
     }