-
Notifications
You must be signed in to change notification settings - Fork 15k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: honor dialog.showMessageBox()'s Icon argument on Linux (#15326)
* Don't call gtk_widget_show_all() on popup dialog. Fixes #15317. Notes: Fixed incorrect display of some GtkMessageDialog icons. The issue is caused because GtkMessageDialog contains an icon widget which is not shown when there's no associated icon. Our call to `gtk_widget_show_all()` overrides this, showing the uninitialized icon widget. This PR fixes the issue by calling `gtk_widget_show()` where needed and removing use of `gtk_widget_show_all()` in the message dialog. * use gtk_dialog_set_default_response() for default * fix: support icons on gtk+ messageboxes.
- Loading branch information
Showing
1 changed file
with
28 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters