fix: allocate accelerator on the stack

electron · Oct 30, 2018 · 880b9bb · 880b9bb
1 parent 7fae6db
commit 880b9bb
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/atom/browser/api/atom_api_menu.cc b/atom/browser/api/atom_api_menu.cc
@@ -156,10 +156,9 @@ base::string16 Menu::GetSublabelAt(int index) const {
 }
 
 base::string16 Menu::GetAcceleratorTextAt(int index) const {
-  auto* accelerator = new ui::Accelerator();
-  model_->GetAcceleratorAtWithParams(index, true, accelerator);
-
-  return accelerator ? accelerator->GetShortcutText() : base::string16();
+  ui::Accelerator accelerator;
+  model_->GetAcceleratorAtWithParams(index, true, &accelerator);
+  return accelerator.GetShortcutText();
 }
 
 bool Menu::IsItemCheckedAt(int index) const {