Skip to content

Commit

Permalink
test: re-enable desktop specs (#33497)
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere committed Mar 29, 2022
1 parent f0c22a7 commit 8ea0631
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions spec-main/api-desktop-capturer-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt

after(closeAllWindows);

// TODO(nornagon): figure out why this test is failing on Linux and re-enable it.
ifit(process.platform !== 'linux')('should return a non-empty array of sources', async () => {
it('should return a non-empty array of sources', async () => {
const sources = await desktopCapturer.getSources({ types: ['window', 'screen'] });
expect(sources).to.be.an('array').that.is.not.empty();
});
Expand All @@ -34,16 +33,15 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
await expect(promise).to.be.eventually.rejectedWith(Error, 'Invalid options');
});

// TODO(nornagon): figure out why this test is failing on Linux and re-enable it.
ifit(process.platform !== 'linux')('does not throw an error when called more than once (regression)', async () => {
it('does not throw an error when called more than once (regression)', async () => {
const sources1 = await desktopCapturer.getSources({ types: ['window', 'screen'] });
expect(sources1).to.be.an('array').that.is.not.empty();

const sources2 = await desktopCapturer.getSources({ types: ['window', 'screen'] });
expect(sources2).to.be.an('array').that.is.not.empty();
});

ifit(process.platform !== 'linux')('responds to subsequent calls of different options', async () => {
it('responds to subsequent calls of different options', async () => {
const promise1 = desktopCapturer.getSources({ types: ['window'] });
await expect(promise1).to.eventually.be.fulfilled();

Expand All @@ -52,7 +50,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
});

// Linux doesn't return any window sources.
ifit(process.platform !== 'linux')('returns an empty display_id for window sources on Windows and Mac', async () => {
ifit(process.platform !== 'linux')('returns an empty display_id for window sources', async () => {
const w = new BrowserWindow({ width: 200, height: 200 });
await w.loadURL('about:blank');

Expand All @@ -64,7 +62,7 @@ ifdescribe(!process.arch.includes('arm') && process.platform !== 'win32')('deskt
}
});

ifit(process.platform !== 'linux')('returns display_ids matching the Screen API on Windows and Mac', async () => {
ifit(process.platform !== 'linux')('returns display_ids matching the Screen API', async () => {
const displays = screen.getAllDisplays();
const sources = await desktopCapturer.getSources({ types: ['screen'] });
expect(sources).to.be.an('array').of.length(displays.length);
Expand Down

0 comments on commit 8ea0631

Please sign in to comment.