chore: don't explicitly destroy asar archives (#15734)

electron · Nov 19, 2018 · 90d1c0b · 90d1c0b
1 parent ec4212c
commit 90d1c0b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/atom/common/api/atom_api_asar.cc b/atom/common/api/atom_api_asar.cc
@@ -39,8 +39,7 @@ class Archive : public mate::Wrappable<Archive> {
         .SetMethod("readdir", &Archive::Readdir)
         .SetMethod("realpath", &Archive::Realpath)
         .SetMethod("copyFileOut", &Archive::CopyFileOut)
-        .SetMethod("getFd", &Archive::GetFD)
-        .SetMethod("destroy", &Archive::Destroy);
+        .SetMethod("getFd", &Archive::GetFD);
   }
 
  protected:
@@ -113,9 +112,6 @@ class Archive : public mate::Wrappable<Archive> {
     return archive_->GetFD();
   }
 
-  // Free the resources used by archive.
-  void Destroy() { archive_.reset(); }
-
  private:
   std::unique_ptr<asar::Archive> archive_;
 

diff --git a/lib/common/asar.js b/lib/common/asar.js
@@ -37,14 +37,6 @@
     return newArchive
   }
 
-  // Clean cache on quit.
-  process.on('exit', () => {
-    for (const archive of cachedArchives.values()) {
-      archive.destroy()
-    }
-    cachedArchives.clear()
-  })
-
   const ASAR_EXTENSION = '.asar'
 
   // Separate asar package's path from full path.