fix: ensure that temporary accelerator is destroyed

electron · Oct 30, 2018 · 976b4d1 · 976b4d1
1 parent 569e264
commit 976b4d1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_menu.cc b/atom/browser/api/atom_api_menu.cc
@@ -156,8 +156,8 @@ base::string16 Menu::GetSublabelAt(int index) const {
 }
 
 base::string16 Menu::GetAcceleratorTextAt(int index) const {
-  auto* accelerator = new ui::Accelerator();
-  model_->GetAcceleratorAtWithParams(index, true, accelerator);
+  std::unique_ptr<ui::Accelerator> accelerator(new ui::Accelerator());
+  model_->GetAcceleratorAtWithParams(index, true, accelerator.get());
 
   return accelerator ? accelerator->GetShortcutText() : base::string16();
 }