fix: console windows from ELECTRON_RUN_AS_NODE instances (#31963)

electron · Nov 23, 2021 · 9ab102e · 9ab102e
1 parent 681fe43
commit 9ab102e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/shell/app/node_main.cc b/shell/app/node_main.cc
@@ -210,8 +210,11 @@ int NodeMain(int argc, char* argv[]) {
       isolate_data = node::CreateIsolateData(isolate, loop, gin_env.platform());
       CHECK_NE(nullptr, isolate_data);
 
-      env = node::CreateEnvironment(isolate_data, gin_env.context(),
-                                    result.args, result.exec_args);
+      uint64_t flags = node::EnvironmentFlags::kDefaultFlags |
+                       node::EnvironmentFlags::kHideConsoleWindows;
+      env = node::CreateEnvironment(
+          isolate_data, gin_env.context(), result.args, result.exec_args,
+          static_cast<node::EnvironmentFlags::Flags>(flags));
       CHECK_NE(nullptr, env);
 
       node::IsolateSettings is;