Skip to content

Commit

Permalink
fix: about panel credits should be dark mode aware
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere committed Jan 23, 2020
1 parent 74acd17 commit 9f48176
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions shell/browser/browser_mac.mm
Expand Up @@ -377,11 +377,22 @@ void RemoveFromLoginItems() {
NSDictionary* options = DictionaryValueToNSDictionary(about_panel_options_);

// Credits must be a NSAttributedString instead of NSString
id credits = options[@"Credits"];
NSString* credits = (NSString*)options[@"Credits"];
if (credits != nil) {
// Check if app is running in dark mode
NSString* mode = [[NSUserDefaults standardUserDefaults]
stringForKey:@"AppleInterfaceStyle"];
BOOL isDarkMode = [mode isEqualToString:@"Dark"];

// Set color of credits depending on if we're in dark mode or not.
NSColor* color = isDarkMode ? [NSColor whiteColor] : [NSColor blackColor];
NSAttributedString* creditString = [[NSAttributedString alloc]
initWithString:credits
attributes:@{NSForegroundColorAttributeName : color}];

// Cast back to NSDictionary with updated options
NSMutableDictionary* mutable_options = [options mutableCopy];
mutable_options[@"Credits"] = [[[NSAttributedString alloc]
initWithString:(NSString*)credits] autorelease];
mutable_options[@"Credits"] = creditString;
options = [NSDictionary dictionaryWithDictionary:mutable_options];
}

Expand Down

0 comments on commit 9f48176

Please sign in to comment.