Skip to content

Commit

Permalink
fix: remove skip-taskbar feature on Linux. (#35156)
Browse files Browse the repository at this point in the history
* fix: remove skip-taskbar feature on Linux.

Marked as unsupported in e19, now removed in e20.

See #33226 for more information

* docs: remove skipTaskbar note in browserWindow

Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
  • Loading branch information
3 people committed Aug 1, 2022
1 parent 0e6f172 commit b61692d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion docs/api/browser-window.md
Expand Up @@ -1323,7 +1323,7 @@ win.setSheetOffset(toolbarRect.height)

Starts or stops flashing the window to attract user's attention.

#### `win.setSkipTaskbar(skip)`
#### `win.setSkipTaskbar(skip)` _macOS_ _Windows_

* `skip` boolean

Expand Down
5 changes: 0 additions & 5 deletions shell/browser/native_window_views.cc
Expand Up @@ -303,14 +303,9 @@ NativeWindowViews::NativeWindowViews(const gin_helper::Dictionary& options,

#if defined(USE_OZONE_PLATFORM_X11)
if (IsX11()) {
// TODO(ckerr): remove in Electron v20.0.0
// Before the window is mapped the SetWMSpecState can not work, so we have
// to manually set the _NET_WM_STATE.
std::vector<x11::Atom> state_atom_list;
bool skip_taskbar = false;
if (options.Get(options::kSkipTaskbar, &skip_taskbar) && skip_taskbar) {
state_atom_list.push_back(x11::GetAtom("_NET_WM_STATE_SKIP_TASKBAR"));
}

// Before the window is mapped, there is no SHOW_FULLSCREEN_STATE.
if (fullscreen) {
Expand Down

0 comments on commit b61692d

Please sign in to comment.