fix: some websites using WebComponents V0 not loading

electron · Jan 22, 2020 · c12adfd · c12adfd
1 parent 100a85f
commit c12adfd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/buildflags/BUILD.gn b/buildflags/BUILD.gn
@@ -21,6 +21,7 @@ buildflag_header("buildflags") {
     "ENABLE_ELECTRON_EXTENSIONS=$enable_electron_extensions",
     "ENABLE_BUILTIN_SPELLCHECKER=$enable_builtin_spellchecker",
     "ENABLE_PICTURE_IN_PICTURE=$enable_picture_in_picture",
+    "ENABLE_WEBCOMPONENTS_V0=$enable_webcomponents_v0",
     "ENABLE_MEDIA_KEY_OVERRIDES=$enable_media_key_overrides",
     "OVERRIDE_LOCATION_PROVIDER=$enable_fake_location_provider",
   ]

diff --git a/buildflags/buildflags.gni b/buildflags/buildflags.gni
@@ -22,6 +22,8 @@ declare_args() {
 
   enable_picture_in_picture = true
 
+  enable_webcomponents_v0 = true
+
   enable_media_key_overrides = true
 
   # Provide a fake location provider for mocking

diff --git a/shell/browser/feature_list.cc b/shell/browser/feature_list.cc
@@ -27,6 +27,12 @@ void InitializeFeatureList() {
   // when node integration is enabled.
   disable_features +=
       std::string(",") + features::kSpareRendererForSitePerProcess.name;
+#if BUILDFLAG(ENABLE_WEBCOMPONENTS_V0)
+  // https://www.polymer-project.org/blog/2018-10-02-webcomponents-v0-deprecations
+  // Any website which uses older WebComponents will currently fail in Electron.
+  enable_features += std::string(",") + "WebComponentsV0Enabled";
+#endif
+
 #if !BUILDFLAG(ENABLE_PICTURE_IN_PICTURE)
   disable_features += std::string(",") + media::kPictureInPicture.name;
 #endif