Update node_debugger.cc

electron · Apr 30, 2019 · cacebb0 · cacebb0
1 parent 9fd5e80
commit cacebb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/atom/browser/node_debugger.cc b/atom/browser/node_debugger.cc
@@ -60,10 +60,7 @@ void NodeDebugger::Start() {
 
 void NodeDebugger::Stop() {
   auto* inspector = env_->inspector_agent();
-  if (inspector == nullptr)
-    return;
-
-  if (inspector->IsListening())
+  if (inspector && inspector->IsListening())
     inspector->Stop();
 }
 

diff --git a/spec/node-spec.js b/spec/node-spec.js
@@ -327,7 +327,8 @@ describe('node feature', () => {
     })
 
     it('does does not crash when quitting with the inspector connected', function (done) {
-      this.timeout(240000)
+      // IPC Electron child process not supported on Windows
+      if (process.platform === 'win32') return this.skip()
       child = ChildProcess.spawn(remote.process.execPath, [path.join(__dirname, 'fixtures', 'module', 'delay-exit'), '--inspect=0'], {
         stdio: ['ipc']
       })