chore: cancel active pending requests if denied

electron · Feb 9, 2022 · d9ea5b7 · d9ea5b7
1 parent 571a6ff
commit d9ea5b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc
@@ -1403,6 +1403,9 @@ void WebContents::RequestExclusivePointerAccess(
   if (allowed) {
     exclusive_access_manager_->mouse_lock_controller()->RequestToLockMouse(
         web_contents, user_gesture, last_unlocked_by_target);
+  } else {
+    web_contents->GotResponseToLockMouseRequest(
+        blink::mojom::PointerLockResult::kPermissionDenied);
   }
 }
 

diff --git a/shell/browser/web_contents_permission_helper.cc b/shell/browser/web_contents_permission_helper.cc
@@ -43,16 +43,6 @@ void MediaAccessAllowed(const content::MediaStreamRequest& request,
     controller.Deny(blink::mojom::MediaStreamRequestResult::PERMISSION_DENIED);
 }
 
-void OnPointerLockResponse(
-    base::OnceCallback<void(content::WebContents*, bool, bool, bool)> callback,
-    content::WebContents* web_contents,
-    bool user_gesture,
-    bool last_unlocked_by_target,
-    bool allowed) {
-  std::move(callback).Run(web_contents, user_gesture, last_unlocked_by_target,
-                          allowed);
-}
-
 void OnPermissionResponse(base::OnceCallback<void(bool)> callback,
                           blink::mojom::PermissionStatus status) {
   if (status == blink::mojom::PermissionStatus::GRANTED)
@@ -162,8 +152,8 @@ void WebContentsPermissionHelper::RequestPointerLockPermission(
         callback) {
   RequestPermission(
       static_cast<content::PermissionType>(PermissionType::POINTER_LOCK),
-      base::BindOnce(&OnPointerLockResponse, std::move(callback), web_contents_,
-                     user_gesture, last_unlocked_by_target),
+      base::BindOnce(std::move(callback), web_contents_, user_gesture,
+                     last_unlocked_by_target),
       user_gesture);
 }