ci: add check for dist zip file changes (#19173)

.circleci/config.yml

@@ -35,6 +35,7 @@ env-debug-build: &env-debug-build
 
 env-testing-build: &env-testing-build
   GN_CONFIG: //electron/build/args/testing.gn
+  CHECK_DIST_MANIFEST: '1'
 
 env-release-build: &env-release-build
   GN_CONFIG: //electron/build/args/release.gn
@@ -254,6 +255,28 @@ step-electron-dist-build: &step-electron-dist-build
     command: |
       cd src
       ninja -C out/Default electron:electron_dist_zip
+      if [ "$CHECK_DIST_MANIFEST" == "1" ]; then
+        if [ "`uname`" == "Darwin" ]; then
+          target_os=mac
+          target_cpu=x64
+          if [ x"$MAS_BUILD" == x"true" ]; then
+            target_os=mac_mas
+          fi
+        elif [ "`uname`" == "Linux" ]; then
+          target_os=linux
+          if [ x"$TARGET_ARCH" == x ]; then
+            target_cpu=x64
+          elif [ "$TARGET_ARCH" == "ia32" ]; then
+            target_cpu=x86
+          else
+            target_cpu="$TARGET_ARCH"
+          fi
+        else
+          echo "Unknown system: `uname`"
+          exit 1
+        fi
+        electron/script/zip_manifests/check-zip-manifest.py out/Default/dist.zip electron/script/zip_manifests/dist_zip.$target_os.$target_cpu.manifest
+      fi
 
 step-electron-dist-store: &step-electron-dist-store
   store_artifacts:

appveyor.yml

@@ -77,6 +77,7 @@ build_script:
         python electron\script\zip-symbols.py
         appveyor PushArtifact out/Default/symbols.zip
       }
+  - python electron/script/zip_manifests/check-zip-manifest.py out/Default/dist.zip electron/script/zip_manifests/dist_zip.win.%TARGET_ARCH%.manifest
 test_script:
   - ps: >-
       if ((-Not (Test-Path Env:\ELECTRON_RELEASE)) -And ($env:GN_CONFIG -in "testing", "release")) {

script/generate-zip-manifest.py

@@ -0,0 +1,14 @@
+#!/usr/bin/env python
+
+import zipfile
+import sys
+
+def main(zip_path, manifest_out):
+  with open(manifest_out, 'w') as manifest, \
+      zipfile.ZipFile(zip_path, 'r', allowZip64=True) as z:
+    for name in sorted(z.namelist()):
+      manifest.write(name + '\n')
+  return 0
+
+if __name__ == '__main__':
+  sys.exit(main(*sys.argv[1:]))

script/zip_manifests/check-zip-manifest.py

@@ -0,0 +1,27 @@
+#!/usr/bin/env python
+
+import zipfile
+import sys
+
+def main(zip_path, manifest_in):
+  with open(manifest_in, 'r') as manifest, \
+      zipfile.ZipFile(zip_path, 'r', allowZip64=True) as z:
+    files_in_zip = set(z.namelist())
+    files_in_manifest = set([l.strip() for l in manifest.readlines()])
+  added_files = files_in_zip - files_in_manifest
+  removed_files = files_in_manifest - files_in_zip
+  if added_files:
+    print("Files added to bundle:")
+    for f in sorted(list(added_files)):
+      print('+' + f)
+  if removed_files:
+    print("Files removed from bundle:")
+    for f in sorted(list(removed_files)):
+      print('-' + f)
+  if added_files or removed_files:
+    return 1
+  else:
+    return 0
+
+if __name__ == '__main__':
+  sys.exit(main(*sys.argv[1:]))

script/zip_manifests/dist_zip.linux.arm.manifest

@@ -0,0 +1,70 @@
+LICENSE
+LICENSES.chromium.html
+chrome-sandbox
+chrome_100_percent.pak
+chrome_200_percent.pak
+electron
+icudtl.dat
+libEGL.so
+libGLESv2.so
+libffmpeg.so
+locales/am.pak
+locales/ar.pak
+locales/bg.pak
+locales/bn.pak
+locales/ca.pak
+locales/cs.pak
+locales/da.pak
+locales/de.pak
+locales/el.pak
+locales/en-GB.pak
+locales/en-US.pak
+locales/es-419.pak
+locales/es.pak
+locales/et.pak
+locales/fa.pak
+locales/fi.pak
+locales/fil.pak
+locales/fr.pak
+locales/gu.pak
+locales/he.pak
+locales/hi.pak
+locales/hr.pak
+locales/hu.pak
+locales/id.pak
+locales/it.pak
+locales/ja.pak
+locales/kn.pak
+locales/ko.pak
+locales/lt.pak
+locales/lv.pak
+locales/ml.pak
+locales/mr.pak
+locales/ms.pak
+locales/nb.pak
+locales/nl.pak
+locales/pl.pak
+locales/pt-BR.pak
+locales/pt-PT.pak
+locales/ro.pak
+locales/ru.pak
+locales/sk.pak
+locales/sl.pak
+locales/sr.pak
+locales/sv.pak
+locales/sw.pak
+locales/ta.pak
+locales/te.pak
+locales/th.pak
+locales/tr.pak
+locales/uk.pak
+locales/vi.pak
+locales/zh-CN.pak
+locales/zh-TW.pak
+natives_blob.bin
+resources.pak
+resources/default_app.asar
+resources/electron.asar
+snapshot_blob.bin
+v8_context_snapshot.bin
+version

script/zip_manifests/dist_zip.linux.arm64.manifest

@@ -0,0 +1,72 @@
+LICENSE
+LICENSES.chromium.html
+chrome-sandbox
+chrome_100_percent.pak
+chrome_200_percent.pak
+electron
+icudtl.dat
+libEGL.so
+libGLESv2.so
+libffmpeg.so
+locales/am.pak
+locales/ar.pak
+locales/bg.pak
+locales/bn.pak
+locales/ca.pak
+locales/cs.pak
+locales/da.pak
+locales/de.pak
+locales/el.pak
+locales/en-GB.pak
+locales/en-US.pak
+locales/es-419.pak
+locales/es.pak
+locales/et.pak
+locales/fa.pak
+locales/fi.pak
+locales/fil.pak
+locales/fr.pak
+locales/gu.pak
+locales/he.pak
+locales/hi.pak
+locales/hr.pak
+locales/hu.pak
+locales/id.pak
+locales/it.pak
+locales/ja.pak
+locales/kn.pak
+locales/ko.pak
+locales/lt.pak
+locales/lv.pak
+locales/ml.pak
+locales/mr.pak
+locales/ms.pak
+locales/nb.pak
+locales/nl.pak
+locales/pl.pak
+locales/pt-BR.pak
+locales/pt-PT.pak
+locales/ro.pak
+locales/ru.pak
+locales/sk.pak
+locales/sl.pak
+locales/sr.pak
+locales/sv.pak
+locales/sw.pak
+locales/ta.pak
+locales/te.pak
+locales/th.pak
+locales/tr.pak
+locales/uk.pak
+locales/vi.pak
+locales/zh-CN.pak
+locales/zh-TW.pak
+natives_blob.bin
+resources.pak
+resources/default_app.asar
+resources/electron.asar
+snapshot_blob.bin
+swiftshader/libEGL.so
+swiftshader/libGLESv2.so
+v8_context_snapshot.bin
+version

script/zip_manifests/dist_zip.linux.x64.manifest

@@ -0,0 +1,72 @@
+LICENSE
+LICENSES.chromium.html
+chrome-sandbox
+chrome_100_percent.pak
+chrome_200_percent.pak
+electron
+icudtl.dat
+libEGL.so
+libGLESv2.so
+libffmpeg.so
+locales/am.pak
+locales/ar.pak
+locales/bg.pak
+locales/bn.pak
+locales/ca.pak
+locales/cs.pak
+locales/da.pak
+locales/de.pak
+locales/el.pak
+locales/en-GB.pak
+locales/en-US.pak
+locales/es-419.pak
+locales/es.pak
+locales/et.pak
+locales/fa.pak
+locales/fi.pak
+locales/fil.pak
+locales/fr.pak
+locales/gu.pak
+locales/he.pak
+locales/hi.pak
+locales/hr.pak
+locales/hu.pak
+locales/id.pak
+locales/it.pak
+locales/ja.pak
+locales/kn.pak
+locales/ko.pak
+locales/lt.pak
+locales/lv.pak
+locales/ml.pak
+locales/mr.pak
+locales/ms.pak
+locales/nb.pak
+locales/nl.pak
+locales/pl.pak
+locales/pt-BR.pak
+locales/pt-PT.pak
+locales/ro.pak
+locales/ru.pak
+locales/sk.pak
+locales/sl.pak
+locales/sr.pak
+locales/sv.pak
+locales/sw.pak
+locales/ta.pak
+locales/te.pak
+locales/th.pak
+locales/tr.pak
+locales/uk.pak
+locales/vi.pak
+locales/zh-CN.pak
+locales/zh-TW.pak
+natives_blob.bin
+resources.pak
+resources/default_app.asar
+resources/electron.asar
+snapshot_blob.bin
+swiftshader/libEGL.so
+swiftshader/libGLESv2.so
+v8_context_snapshot.bin
+version

script/zip_manifests/dist_zip.linux.x86.manifest

@@ -0,0 +1,72 @@
+LICENSE
+LICENSES.chromium.html
+chrome-sandbox
+chrome_100_percent.pak
+chrome_200_percent.pak
+electron
+icudtl.dat
+libEGL.so
+libGLESv2.so
+libffmpeg.so
+locales/am.pak
+locales/ar.pak
+locales/bg.pak
+locales/bn.pak
+locales/ca.pak
+locales/cs.pak
+locales/da.pak
+locales/de.pak
+locales/el.pak
+locales/en-GB.pak
+locales/en-US.pak
+locales/es-419.pak
+locales/es.pak
+locales/et.pak
+locales/fa.pak
+locales/fi.pak
+locales/fil.pak
+locales/fr.pak
+locales/gu.pak
+locales/he.pak
+locales/hi.pak
+locales/hr.pak
+locales/hu.pak
+locales/id.pak
+locales/it.pak
+locales/ja.pak
+locales/kn.pak
+locales/ko.pak
+locales/lt.pak
+locales/lv.pak
+locales/ml.pak
+locales/mr.pak
+locales/ms.pak
+locales/nb.pak
+locales/nl.pak
+locales/pl.pak
+locales/pt-BR.pak
+locales/pt-PT.pak
+locales/ro.pak
+locales/ru.pak
+locales/sk.pak
+locales/sl.pak
+locales/sr.pak
+locales/sv.pak
+locales/sw.pak
+locales/ta.pak
+locales/te.pak
+locales/th.pak
+locales/tr.pak
+locales/uk.pak
+locales/vi.pak
+locales/zh-CN.pak
+locales/zh-TW.pak
+natives_blob.bin
+resources.pak
+resources/default_app.asar
+resources/electron.asar
+snapshot_blob.bin
+swiftshader/libEGL.so
+swiftshader/libGLESv2.so
+v8_context_snapshot.bin
+version