Skip to content

Commit

Permalink
Add patch removal plan
Browse files Browse the repository at this point in the history
  • Loading branch information
codebytere committed Jul 15, 2020
1 parent bec5073 commit debb4bf
Showing 1 changed file with 7 additions and 1 deletion.
Expand Up @@ -5,7 +5,13 @@ Subject: fix: do not register the ESM loader in renderer processes

Only one ESM loader can be registered per isolate, in renderer processes this should be blink. This patches node so that it won't register it's handler (overriding blinks) in non-browser processes.

This can be attempted to be upstreamed as a new option --disable-esm-loader or something similar.
This has been upstreamed in:
* https://github.com/nodejs/node/pull/34060
* https://github.com/nodejs/node/pull/34127

We can't easily rebase on that accepted solution here but we can as soon as we upgrade to
Node.js v14, since we need to leverage the new version of node::CreateEnvironment
introduced in https://github.com/nodejs/node/pull/30467.

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
index b4a0f71af5853f427a10449b52509052fbe3facd..ba5b0b6e51bcddbc5b9dd9c31231585d61b131a0 100644
Expand Down

0 comments on commit debb4bf

Please sign in to comment.