Add electron version to framework

electron · Aug 24, 2018 · dfb4265 · dfb4265
1 parent e6e3ccf
commit dfb4265
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/BUILD.gn b/BUILD.gn
@@ -494,7 +494,7 @@ if (is_mac) {
       deps += [ ":electron_crashpad_helper" ]
     }
     info_plist = "atom/common/resources/mac/Info.plist"
-    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework" ]
+    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework", "ELECTRON_VERSION=$electron_version" ]
 
     include_dirs = [ "." ]
     sources = filenames_gypi.framework_sources

diff --git a/atom/common/resources/mac/Info.plist b/atom/common/resources/mac/Info.plist
@@ -12,5 +12,7 @@
 	<string>FMWK</string>
 	<key>NSSupportsAutomaticGraphicsSwitching</key>
 	<true/>
+	<key>Version</key>
+	<string>${ELECTRON_VERSION}</string>
 </dict>
 </plist>