chore: remove redundant RegisterPreference impl

electron · Mar 3, 2022 · e243a25 · e243a25
1 parent 448c526
commit e243a25
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/shell/browser/ui/inspectable_web_contents.cc b/shell/browser/ui/inspectable_web_contents.cc
@@ -853,18 +853,6 @@ void InspectableWebContents::SendJsonRequest(DispatchCallback callback,
   std::move(callback).Run(nullptr);
 }
 
-void InspectableWebContents::RegisterPreference(
-    const std::string& name,
-    const RegisterOptions& options) {
-  const std::string* settings_value =
-      pref_service_->GetDictionary(kDevToolsPreferences)->FindStringKey(name);
-  if (!settings_value)
-    return;
-
-  DictionaryPrefUpdate insert_update(pref_service_, kDevToolsPreferences);
-  insert_update.Get()->SetKey(name, base::Value(*settings_value));
-}
-
 void InspectableWebContents::GetPreferences(DispatchCallback callback) {
   const base::Value* prefs = pref_service_->GetDictionary(kDevToolsPreferences);
   std::move(callback).Run(prefs);

diff --git a/shell/browser/ui/inspectable_web_contents.h b/shell/browser/ui/inspectable_web_contents.h
@@ -140,7 +140,7 @@ class InspectableWebContents
                        const std::string& browser_id,
                        const std::string& url) override;
   void RegisterPreference(const std::string& name,
-                          const RegisterOptions& options) override;
+                          const RegisterOptions& options) override {}
   void GetPreferences(DispatchCallback callback) override;
   void GetPreference(DispatchCallback callback,
                      const std::string& name) override;