Skip to content

Commit

Permalink
ci: enable thin LTO on Mac (#33194) (#33387)
Browse files Browse the repository at this point in the history
* build: remove thin lto mac patch

* build: remove step-get-more-space-on-mac

* build: remove USE_PREBUILT_V8_CONTEXT_SNAPSHOT

* ci: re-add mksnapshot logic

* ci: re-add USE_PREBUILT_V8_CONTEXT_SNAPSHOT

* ci: re-add get-more-space, delete thin LTO cache & .dSYM

* ci: don't delete v8_snapshot_generator.dSYM

* ci: add timeout to mksnapshot

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
  • Loading branch information
trop[bot] and VerteDinde committed Mar 23, 2022
1 parent 1763f4c commit e5c56c0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 23 deletions.
2 changes: 2 additions & 0 deletions .circleci/build_config.yml
Expand Up @@ -543,6 +543,7 @@ step-electron-build: &step-electron-build
(cd out/Default; zip mksnapshot.zip mksnapshot_args clang_x64_v8_arm64/gen/v8/embedded.S)
rm -rf out/Default/clang_x64_v8_arm64/gen
rm -rf out/Default/clang_x64_v8_arm64/obj
rm -rf out/Default/clang_x64_v8_arm64/thinlto-cache
rm -rf out/Default/clang_x64/obj
# Regenerate because we just deleted some ninja files
Expand Down Expand Up @@ -779,6 +780,7 @@ step-show-goma-stats: &step-show-goma-stats
step-mksnapshot-build: &step-mksnapshot-build
run:
name: mksnapshot build
no_output_timeout: 30m
command: |
cd src
if [ "$USE_PREBUILT_V8_CONTEXT_SNAPSHOT" != "1" ]; then
Expand Down
1 change: 0 additions & 1 deletion patches/chromium/.patches
Expand Up @@ -112,6 +112,5 @@ feat_add_data_transfer_to_requestsingleinstancelock.patch
fix_crash_when_saving_edited_pdf_files.patch
port_autofill_colors_to_the_color_pipeline.patch
build_disable_partition_alloc_on_mac.patch
build_disable_thin_lto_on_mac.patch
fix_non-client_mouse_tracking_and_message_bubbling_on_windows.patch
remove_incorrect_width_height_adjustments.patch
22 changes: 0 additions & 22 deletions patches/chromium/build_disable_thin_lto_on_mac.patch

This file was deleted.

0 comments on commit e5c56c0

Please sign in to comment.