fix: ProxyWebSocket hitting DCHECK

electron · Apr 7, 2020 · e838729 · e838729
1 parent ad12645
commit e838729
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc
@@ -1356,9 +1356,12 @@ void ElectronBrowserClient::CreateWebSocket(
           browser_context);
 
   DCHECK(web_request_api);
-  web_request_api->ProxyWebSocket(frame, std::move(factory), url,
-                                  site_for_cookies.RepresentativeUrl(),
-                                  user_agent, std::move(handshake_client));
+
+  if (web_request_api->MayHaveProxies()) {
+    web_request_api->ProxyWebSocket(frame, std::move(factory), url,
+                                    site_for_cookies.RepresentativeUrl(),
+                                    user_agent, std::move(handshake_client));
+  }
 #endif
 
   v8::Isolate* isolate = v8::Isolate::GetCurrent();